Skip to content

Move more intrinsics to rustc_intrinsic #122037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 19, 2024
Merged

Move more intrinsics to rustc_intrinsic #122037

merged 5 commits into from
Mar 19, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 5, 2024 •
edited
Loading

cc #63585

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

r? @Nilstrieb

rustbot has assigned @Nilstrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

compiler-errors
compiler-errors reviewed Mar 5, 2024
View reviewed changes
@oli-obk oli-obk force-pushed the more_new_intrinsics branch 2 times, most recently from bcd98af to 7669f57 Compare March 5, 2024 18:07
@bors
Copy link
Collaborator

bors commented Mar 6, 2024

☔ The latest upstream changes (presumably #122045) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the more_new_intrinsics branch from 7669f57 to bbc88ef Compare March 7, 2024 10:04
@bors
Copy link
Collaborator

bors commented Mar 9, 2024

☔ The latest upstream changes (presumably #122241) made this pull request unmergeable. Please resolve the merge conflicts.

Noratrieb
Noratrieb reviewed Mar 9, 2024
View reviewed changes
@oli-obk oli-obk force-pushed the more_new_intrinsics branch from bbc88ef to 095eb69 Compare March 12, 2024 14:04
Noratrieb
Noratrieb reviewed Mar 12, 2024
View reviewed changes
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 12, 2024

@rustbot author

Need to add the abort, otherwise screwing up and invoking the body causes UB

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 13, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2024
RalfJung
RalfJung reviewed Mar 14, 2024
View reviewed changes
@Noratrieb
Copy link
Member

at that point I'd prefer to use the Unreachable terminator in this PR or add the Abort terminator in a separate PR (I'm inclined to use the Unreachable terminator since that should still often result in crashes and adding a new terminator seems like a lot of stuff for just the intrinsics, unless there are other use cases for it)

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 14, 2024

I removed the Abort terminator change

@oli-obk oli-obk force-pushed the more_new_intrinsics branch from 4b64211 to ff12979 Compare March 14, 2024 12:07
@Noratrieb
Copy link
Member

@bors r+
thanks!

@bors
Copy link
Collaborator

bors commented Mar 18, 2024

📌 Commit ff12979 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 18, 2024
@oli-obk oli-obk mentioned this pull request Mar 18, 2024
Closed
@bors
Copy link
Collaborator

bors commented Mar 18, 2024

☔ The latest upstream changes (presumably #122690) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2024
@oli-obk oli-obk force-pushed the more_new_intrinsics branch from ff12979 to a8f71cf Compare March 19, 2024 09:33
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 19, 2024

@bors r=Nilstrieb

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

📌 Commit a8f71cf has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2024
@bors
Copy link
Collaborator

bors commented Mar 19, 2024

⌛ Testing commit a8f71cf with merge 200e3f7...

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 200e3f7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2024
@bors bors merged commit 200e3f7 into rust-lang:master Mar 19, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 19, 2024
@bors bors mentioned this pull request Mar 19, 2024
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (200e3f7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.3%, -0.2%] 4
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.3% [-0.3%, -0.2%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-2.7%, -2.6%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.996s -> 669.309s (-0.10%)
Artifact size: 312.80 MiB -> 312.82 MiB (0.01%)

@oli-obk oli-obk deleted the more_new_intrinsics branch March 19, 2024 17:13
@Veykril Veykril mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@Noratrieb Noratrieb Noratrieb left review comments

Assignees

@Noratrieb Noratrieb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oli-obk @rustbot @bors @Noratrieb @rust-timer @RalfJung @compiler-errors